Fix how the nexus repositories are added #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes yet another ordering issue. The use of `afterEvaluate` on _any_ project to add configuration to the _root_ project is doomed to fail in some form. Here, it was possible that the configuration of a child module was completed before the root project was. In this case, the Nexus repository wouldn't be added, which leads to incomplete publications! This commit fixes the problem by making sure that the repository is added first. It also introduces a sanity check to make sure that if the plugin is updated, it also comes with the application of the settings plugin.
melix
added
bug
|
@ilopmar I leveraged this bugfix to introduce a check which would warn you if you forgot to apply the settings plugin |
ilopmar
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes yet another ordering issue. The use of
afterEvaluateonany project to add configuration to the root project is doomed to fail in
some form. Here, it was possible that the configuration of a child module was
completed before the root project was. In this case, the Nexus repository
wouldn't be added, which leads to incomplete publications!
This commit fixes the problem by making sure that the repository is added
first. It also introduces a sanity check to make sure that if the plugin is
updated, it also comes with the application of the settings plugin.