Implement setParent() for SimpleTracer, implement assertions for parentId #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
approved these changes
Apr 22, 2024
...ests/micrometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/SpanAssert.java
Outdated
Show resolved
Hide resolved
...ests/micrometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/SpanAssert.java
Outdated
Show resolved
Hide resolved
...ests/micrometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/SpanAssert.java
Outdated
Show resolved
Hide resolved
| SimpleTracer simpleTracer = new SimpleTracer(); | ||
| SimpleSpanBuilder builder = new SimpleSpanBuilder(simpleTracer); | ||
| SimpleTraceContextBuilder ctxBuilder = new SimpleTraceContextBuilder(); | ||
| TraceContext parentCtx = ctxBuilder.spanId("spam").traceId("bar").sampled(true).build(); |
...micrometer-tracing-test/src/test/java/io/micrometer/tracing/test/simple/SpanAssertTests.java
Show resolved
Hide resolved
...micrometer-tracing-test/src/test/java/io/micrometer/tracing/test/simple/SpanAssertTests.java
Outdated
Show resolved
Hide resolved
jonatan-ivanov
requested changes
Apr 22, 2024
marcingrzejszczak
approved these changes
May 6, 2024
shakuzen
approved these changes
May 9, 2024
|
@jonatan-ivanov any more notes for this one? |
jonatan-ivanov
approved these changes
May 13, 2024
|
@jamesmoessis Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675
I've also added assertions for parent ID since they didn't exist before, and it was useful for testing the change to SimpleTracer.