Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotation as parameter to avoid using string literal FQCN #311

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jul 18, 2023

Align to CountedAspect in micrometer

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 18, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@marcingrzejszczak
Copy link
Contributor

Hey, thanks for the PR. What problem is this solving?

@quaff
Copy link
Contributor Author

quaff commented Sep 15, 2023

Hey, thanks for the PR. What problem is this solving?

Polishing for keeping consistency with CountedAspect.

@shakuzen
Copy link
Member

It's the same change as done in micrometer-metrics/micrometer#3780 to resolve the problem mentioned in micrometer-metrics/micrometer#3776

@shakuzen
Copy link
Member

That said, I don't think we have the problem here since the annotation is not used as a method parameter. That's the same as we didn't have the issue with TimedAspect in micrometer, even though we had it with CountedAspect. So, I'll close this for now, unless we are having the issue with SpanAspect without these changes.

@shakuzen shakuzen closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants