fix: AnnotationHandler should read annotations from parent class #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure, but it looks like it may have been a mistake. I don't see the line in the original pull request #3727, but I see it in the follow-up commit bc59c47. I'm not sure where it came from. |
shakuzen
force-pushed
the
AnnotationHandler_cannot_see_methods_from_parent_class
branch
from
80d102f
to
fb3a535
Compare
shakuzen
approved these changes
Apr 24, 2024
|
@bpernetupgrade would you mind taking a look? Does the test capture the scenario you had in mind? Any other tests you think we should add? |
@shakuzen I am not super familiar with AspectJ, but yeah the test scenario is correct and matched the situation I encountered. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4983 which is a regression from #4506
AnnotationHandlershould be able to read annotations from parent class.The fix is really simple (too simple? why was it there in the first place?), just removing a redundant line in
AnnotationHandler.The new test case and all existing test cases passes.