For long task timers fixes the percentiles above interpolatable line #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcingrzejszczak
force-pushed
the
issues_#3877
branch
from
4aec46f
to
421ff5b
Compare
shakuzen
reviewed
Jan 17, 2024
| SimpleMeterRegistry simpleMeterRegistry = new SimpleMeterRegistry(); | ||
|
|
||
| LongTaskTimer timer = LongTaskTimer.builder("jobrunr.jobs") | ||
| .publishPercentiles(0.25, 0.5, 0.75, 0.8, 0.9, 0.95) |
There was a problem hiding this comment.
The test fails if this is changed to the other example given in the issue: 0.11, 0.22, 0.33, 0.44. I'm not sure why it makes a difference to be honest but the following change makes both cases pass without the change to DefaultLongTaskTimer.
Index: micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/HistogramGauges.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/HistogramGauges.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/HistogramGauges.java
--- a/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/HistogramGauges.java (revision e38f5e87dac6566e7909628afa7aa4f7fde6f170)
+++ b/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/HistogramGauges.java (date 1705478240207)
@@ -116,7 +116,7 @@
ToDoubleFunction<HistogramSupport> percentileValueFunction = m -> {
snapshotIfNecessary();
polledGaugesLatch.countDown();
- return percentileValue.apply(snapshot.percentileValues()[index]);
+ return percentileValue.apply(valueAtPercentiles[index]);
};
Gauge.builder(percentileName.apply(valueAtPercentiles[i]), meter, percentileValueFunction)There was a problem hiding this comment.
My suggested change is not correct. We definitely need more tests in this area of the code to be confident the behavior is correct. I'll take a closer look tomorrow soon.
without this change for the provided test one of the histogram buckets gets removed and an ArrayIndexOutOfBoundsException is thrown with this change the exception is not thrown anymore fixes gh-3877
marcingrzejszczak
force-pushed
the
issues_#3877
branch
from
421ff5b
to
954916d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this change for the provided test one of the histogram buckets gets removed and an ArrayIndexOutOfBoundsException is thrown with this change the exception is not thrown anymore
fixes gh-3877