Allow specifying the meterNameConsumer for HighCardinalityTagsDetector #4028
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sean-heller Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@sean-heller Thank you for signing the Contributor License Agreement! |
sean-heller
force-pushed
the
sh_AllowOverridingHCTD
branch
from
993b246
to
e2e9029
Compare
alexey-vasin
approved these changes
Aug 11, 2023
| @@ -107,4 +122,21 @@ public String getName() { | |||
|
|
|||
| } | |||
|
|
|||
| private static class TestCustomMeterNameConsumer implements Consumer<String> { | |||
|
|
|||
| @Nullable | |||
There was a problem hiding this comment.
Why do you need such annotations in test code? Seems like an overkill to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to specify the
meterNameConsumer, so folks are just left with the default functionality of logging a warning then logging debug messages.This change would allow for users to specify their own consumer - one use case for this would be to add a new metric that is marked every time there is a metric with high cardinality detected, which could be used for alerting (vs. just looking through logs).
Let me know what you think! Thanks!