[Dynatrace] Log NaNs at DEBUG instead of WARNING #3557
Merged
+28
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
approved these changes
Dec 6, 2022
pirgeo
force-pushed
the
log-nan-debug
branch
from
b4ce116 to
2952670
Compare
|
Rebased on https://github.com/micrometer-metrics/micrometer/tree/1.9.x and pointed the PR to that branch. |
arminru
approved these changes
Dec 19, 2022
|
@jonatan-ivanov Is there anything that needs to be done to move this PR forward? |
shakuzen
added
bug
shakuzen
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the object behind the weak reference of a Gauge meter is garbage collected, it will fall back to reporting NaN. The Dynatrace exporter would generate a warning log for each NaN generated that way. This bugfix changes the code to only log the first NaN at warning level (including some hints for the user) and all subsequent NaNs at debug level to prevent spamming the logs with lots of warnings.
Is it possible to get this into 1.9.x versions, and if so, is there anything in particular that I need to do to this PR?