-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CircleCI images to the latest #3550
Update CircleCI images to the latest #3550
Conversation
Builds fail with the following test failures:
Embedded MongoDB doesn't seem to support JDK 19, but I couldn't reproduce it locally with OpenJDK 19.0.1. |
I tried to resolve it by upgrading to Embedded MongoDB 3.5.3, but it made things even worse as now it's failing with JDK 11 and JDK 17 too as follows:
|
Now that |
84e3f86
to
b0a7f10
Compare
🛠 Lift Auto-fixSome of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1 # Download the patch
curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/micrometer/3550.diff -o lift-autofixes.diff
# Apply the patch with git
git apply lift-autofixes.diff
# Review the changes
git diff Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command: curl https://lift.sonatype.com/api/patch/github.com/micrometer-metrics/micrometer/3550.diff | git apply Once you're satisfied commit and push your changes in your project. Footnotes |
I'm not sure why, but all the tests have passed with the same versions 🤷 |
b0a7f10
to
df3cb52
Compare
I updated the images to the "current" latest versions, and all the tests have passed. |
I only have one idea: since Docker tags are not immutable, maybe something was fixed on the same version (tag). |
This PR updates CircleCI images to the latest.