Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic to choose ObservationConvention #3544

Merged
merged 1 commit into from Nov 23, 2022
Merged

Fix logic to choose ObservationConvention #3544

merged 1 commit into from Nov 23, 2022

Conversation

jonatan-ivanov
Copy link
Member

fixes gh-3543

ttddyy
ttddyy reviewed Nov 23, 2022
View reviewed changes
micrometer-observation/src/main/java/io/micrometer/observation/Observation.java
@@ -380,8 +428,8 @@ default boolean isNoop() {

/**
* Adds an observation convention that can be used to attach key values to the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change Adds to Sets.

Also, do we want to deprecate this method as we discussed offline?

The actual implementation only set the convention if it supports the context. Wondering should it also be documented?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3f0ca2f, thanks for catching it.

I think we should deprecate it, but:

  • I think it should happen in 1.11
  • We need more discussions about the potential use-cases and consequences

I added a note about setting the convention in 22a81f0 thank you for noticing it.

@marcingrzejszczak marcingrzejszczak added this to the 1.10.2 milestone Nov 23, 2022
@marcingrzejszczak marcingrzejszczak changed the base branch from main to 1.10.x November 23, 2022 11:49
@marcingrzejszczak marcingrzejszczak added the bug A general bug label Nov 23, 2022
@marcingrzejszczak marcingrzejszczak merged commit c9dad1f into micrometer-metrics:1.10.x Nov 23, 2022
@jonatan-ivanov jonatan-ivanov deleted the observation-convention-choosing-logic-fix branch November 23, 2022 17:47
@jonatan-ivanov jonatan-ivanov removed the bug A general bug label Nov 23, 2022
@jonatan-ivanov jonatan-ivanov removed this from the 1.10.2 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttddyy ttddyy ttddyy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix logic to choose ObservationConvention
3 participants
@jonatan-ivanov @ttddyy @marcingrzejszczak