Add "get[Low|High]CardinalityKeyValue()" on "Observation.Context" #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
approved these changes
Oct 26, 2022
|
|
shakuzen
approved these changes
Oct 28, 2022
ttddyy
force-pushed
the
use-map-for-keyvalue
branch
from
6ab775c
to
e9ad06c
Compare
Add two new methods `getLowCardinalityKeyValue` and `getHighCardinalityKeyValue`. Also, changes the internal holder from `Set` to `Map`. Prior to this change, the usage of `LinkedHashSet` allowed multiple `KeyValue`s with the same key. It was deduped when converted to `KeyValues`, but it is not an ideal implementation. This change replaces the `LinkedHashSet` with `LinkedHashMap` using the key from `KeyValue` as a map key. This way, when a new `KeyValue` is added, it will override the old `KeyValue` with the same key.
ttddyy
force-pushed
the
use-map-for-keyvalue
branch
from
e9ad06c
to
caa42bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new methods
getLowCardinalityKeyValueandgetHighCardinalityKeyValue.Also, changes the internal holder from
SettoMap.Prior to this change, the usage of
LinkedHashSetallowed multipleKeyValue with the same key. It was deduped when converted toKeyValues`, but it is not an ideal implementation.This change replaces the
LinkedHashSetwithLinkedHashMapusing the key fromKeyValueas a map key. This way, when a newKeyValueis added, it will override the oldKeyValuewith the same key.