Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http client instrumentation TCK #3258

Merged
merged 10 commits into from
Jul 11, 2022
Merged

Http client instrumentation TCK #3258

merged 10 commits into from
Jul 11, 2022

Commits on Jul 11, 2022

  1. WIP Http client instrumentation TCK 

    Introduce test suite for HTTP client instrumentations to check that all implementations have the naming and tags expected. This may also help instrumentors ensure backwards compatibility of the HTTP client instrumentation across changes to it.
    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    066d4b9 View commit details
    Browse the repository at this point in the history

  2. Clean up API to be more versatile and less leaky 

    Avoids putting WireMock classes in the API that instrumentors need to implement for the test suite. Also makes it more versatile by passing a method, templated path, and variable substitutions. How templated paths are handled will vary from client to client.
    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    c950a2c View commit details
    Browse the repository at this point in the history

  3. Fix build check issues

    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    fed9baa View commit details
    Browse the repository at this point in the history

  4. Polish JavaDocs

    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    ad8a7bb View commit details
    Browse the repository at this point in the history

  5. Assert more specific behavior of expected tags 

    Each implementation has been configured to tag with the URI pattern and that is checked now. Unmapped paths, on the other hand, should not be tagged as requested in the URI. This is currently failing for the Apache HTTP instrumentation.
    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    36ed1bd View commit details
    Browse the repository at this point in the history

  6. Use more standard naming, polish 

    Rename classes to be standard test class names. Minimize visibility. Remove 404 test, add a disabled test for requests to a down server. We will need to improve the existing instrumentations to add more tests of expected behavior such as that test.
    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    292e62b View commit details
    Browse the repository at this point in the history

  7. Fix formatting

    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    1d90996 View commit details
    Browse the repository at this point in the history

  8. Mark as incubating, add client exception

    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    3c74cfd View commit details
    Browse the repository at this point in the history

  9. Add body parameter for potential future use 

    We want to test more than the GET method, and some HTTP clients require a body for POST requests.
    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    aa07c38 View commit details
    Browse the repository at this point in the history

  10. Write locks for 1.8.x

    @shakuzen
    shakuzen committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    b5c3e49 View commit details
    Browse the repository at this point in the history