Use index prefix for template index pattern in ElasticMeterRegistry #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
approved these changes
Sep 17, 2020
|
Hi, I'm not 100% sure, if this is the cause, but it seems related. The build produced from this |
micheljung
reviewed
Jan 6, 2021
| " \"index_patterns\": [\"metrics*\"],\n" + | ||
| private static final Function<String, String> TEMPLATE_BODY_BEFORE_VERSION_7 = (indexPrefix) -> "{\"template\":\"" + indexPrefix + "*\",\"mappings\":{\"_default_\":{\"_all\":{\"enabled\":false}," + TEMPLATE_PROPERTIES + "}}}"; | ||
| private static final Function<String, String> TEMPLATE_BODY_AFTER_VERSION_7 = (indexPrefix) -> "{\n" + | ||
| " \"index_patterns\": [\"" + indexPrefix + "*\"],\n" + |
There was a problem hiding this comment.
Actually though, I think the pattern should include config.indexDateSeparator()
Otherwise, the index is foo-2020-07-20 but the pattern is foo*, potentially matching foobar-2020-07-20 as well.
There was a problem hiding this comment.
I just saw that my comment was still pending. I'll post it anyway now :)
There was a problem hiding this comment.
@micheljung Thanks! I created #2405 to try to resolve it.
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Jan 13, 2021
shakuzen
pushed a commit
that referenced
this pull request
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to use index prefix for template index pattern in
ElasticMeterRegistry.Closes gh-2196