Add illegal import check for Java6Assertions #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
reviewed
Dec 4, 2019
config/checkstyle/checkstyle.xml
Outdated
| @@ -27,6 +27,12 @@ | |||
| value="Line has leading tab characters; indentation should be performed with spaces only." /> | |||
| <property name="ignoreComments" value="true" /> | |||
| </module> | |||
| <module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck"> | |||
There was a problem hiding this comment.
Could we use the IllegalImportCheck's illegalClasses property instead? I think the regex here will also work, but it just seems more straightforward to use the IllegalImportCheck. I'm not sure of its behavior when importing a static method from one of the illegalClasses.
https://checkstyle.org/config_imports.html#IllegalImport
izeye
force-pushed
the
checkstyle-assertj
branch
from
c2269c6
to
903716d
Compare
izeye
changed the title
shakuzen
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Checkstyle rule for
org.assertj.core.api.Java6Assertions.See #1729 (comment)