Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic to choose ObservationConvention #3543

Closed
jonatan-ivanov opened this issue Nov 23, 2022 · 0 comments · Fixed by #3544
Closed

Fix logic to choose ObservationConvention #3543

jonatan-ivanov opened this issue Nov 23, 2022 · 0 comments · Fixed by #3544
Labels
bug A general bug
Milestone

Comments

@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented Nov 23, 2022

There are two issues with the logic that chooses and applies the ObservationConvention on the Observations.

  1. The logic can choose and apply multiple conventions, also in one case it can mix them together
  2. In one case the logic pics the wrong convention

Here's the old and the new decision matrix:

OLD:

1. custom     default     no pre-cofigured  -> custom
2. custom     default     pre-cofigured     -> custom on top of pre-cofigured
3. no custom  default     no pre-cofigured  -> default
4. no custom  default     pre-cofigured     -> default on top of pre-cofigured (*)
5. custom     no default  no pre-cofigured  -> custom
6. custom     no default  pre-cofigured     -> custom on top of pre-cofigured
7. no custom  no default  no pre-cofigured  -> local
8. no custom  no default  pre-cofigured     -> pre-cofigured

(*): This logic is wrong: 1. they are mixed, 2. pre-cofigured should have choosen

NEW:

1. custom     default     no pre-configured  -> custom
2. custom     default     pre-configured     -> custom (not really a valid case, use custom)
3. no custom  default     no pre-configured  -> default
4. no custom  default     pre-configured     -> pre-configured
5. custom     no default  no pre-configured  -> custom (providing default is recommended)
6. custom     no default  pre-configured     -> custom (providing default is recommended)
7. no custom  no default  no pre-configured  -> local names/tags will be used
8. no custom  no default  pre-configured     -> pre-configured

cc: @bclozel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant