Skip to content

Commit

Permalink
Deprecate ReactorNettySender (#2814)
Browse files Browse the repository at this point in the history
Having code in micrometer-core that depends on reactor-netty creates a dependency cycle between the two projects. In an effort to work towards eliminating that cycle, we are proactively deprecating the ReactorNettySender. If we receive feedback that users have use cases for it, we can consider moving it to the reactor-netty project or elsewhere. Lacking enough feedback, we will plan to remove this in the next feature release.

See gh-2802
  • Loading branch information
shakuzen committed Oct 13, 2021
1 parent d918113 commit fc2bae0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
Expand Up @@ -25,7 +25,9 @@
*
* @author Jon Schneider
* @since 1.1.0
* @deprecated use a different {@link HttpSender} implementation or report your use case for this to the Micrometer project maintainers
*/
@Deprecated
public class ReactorNettySender implements HttpSender {
private final HttpClient httpClient;

Expand Down
Expand Up @@ -29,6 +29,7 @@
import static com.github.tomakehurst.wiremock.client.WireMock.*;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;

@SuppressWarnings("deprecation")
@ExtendWith(WiremockResolver.class)
class ReactorNettySenderTests {
HttpSender httpSender = new ReactorNettySender();
Expand Down

0 comments on commit fc2bae0

Please sign in to comment.