Skip to content

Commit

Permalink
Remove ReactorNettySender
Browse files Browse the repository at this point in the history
In 1.8, we deprecated the ReactorNettySender for removal. This completes that removal, which gets rid of the dependency cycle between micrometer-core and reactor-netty/reactor-core. Users should use one of the alternate HttpSender implementations or copy the ReactorNettySender implementation to their own code. If there is demand, we could seek to find a home for it in the Reactor Netty project, which would avoid the current dependency cycle.

Resolves gh-2802
  • Loading branch information
shakuzen committed Dec 17, 2021
1 parent bfdb43e commit 35c5ef9
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 151 deletions.
4 changes: 0 additions & 4 deletions micrometer-core/build.gradle
Expand Up @@ -38,10 +38,6 @@ dependencies {
optionalApi 'ch.qos.logback:logback-classic'
optionalApi 'org.apache.logging.log4j:log4j-core'

// reactor
optionalApi 'io.projectreactor:reactor-core'
optionalApi 'io.projectreactor.netty:reactor-netty-http'

// @Timed AOP
optionalApi 'org.aspectj:aspectjweaver'

Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

2 comments on commit 35c5ef9

@patpatpat123
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @shakuzen

Thank you for this PR.
I did "copy the ReactorNettySender implementation to their own code"

However, Micrometer is not picking it up to send traces. With debug log enabled, it is still using the default HttpUrlConnectionSender.java

How do I pass the ReactorNettySender to micrometer please

@shakuzen
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue with information about what registry you are using. You should be able to configure the registry to use a different implementation of HttpSender

Please sign in to comment.