Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In 1.8, we deprecated the ReactorNettySender for removal. This completes that removal, which gets rid of the dependency cycle between micrometer-core and reactor-netty/reactor-core. Users should use one of the alternate HttpSender implementations or copy the ReactorNettySender implementation to their own code. If there is demand, we could seek to find a home for it in the Reactor Netty project, which would avoid the current dependency cycle. Resolves gh-2802
- Loading branch information
Showing
4 changed files
with
0 additions
and
151 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 0 additions & 75 deletions
75
micrometer-core/src/main/java/io/micrometer/core/ipc/http/ReactorNettySender.java
This file was deleted.
Oops, something went wrong.
48 changes: 0 additions & 48 deletions
48
micrometer-core/src/test/java/io/micrometer/core/ipc/http/ReactorNettySenderTests.java
This file was deleted.
Oops, something went wrong.
24 changes: 0 additions & 24 deletions
24
micrometer-test/src/test/java/io/micrometer/core/ipc/http/ReactorNettySenderTest.java
This file was deleted.
Oops, something went wrong.
35c5ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @shakuzen
Thank you for this PR.
I did "copy the ReactorNettySender implementation to their own code"
However, Micrometer is not picking it up to send traces. With debug log enabled, it is still using the default HttpUrlConnectionSender.java
How do I pass the ReactorNettySender to micrometer please
35c5ef9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open an issue with information about what registry you are using. You should be able to configure the registry to use a different implementation of
HttpSender