Skip to content

Commit

Permalink
Log ExecutorServiceMetrics.bindTo() failure (#2443)
Browse files Browse the repository at this point in the history
* Log ExecutorServiceMetrics.bindTo() failure

See gh-2426

* Fix a wrong class reference for a logger

Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>

* Use conventional order for modifiers

Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>

Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
  • Loading branch information
izeye and jonatan-ivanov committed Feb 11, 2021
1 parent 32b2e19 commit 1dd19e6
Showing 1 changed file with 7 additions and 0 deletions.
Expand Up @@ -25,6 +25,8 @@
import io.micrometer.core.lang.NonNullApi;
import io.micrometer.core.lang.NonNullFields;
import io.micrometer.core.lang.Nullable;
import io.micrometer.core.util.internal.logging.InternalLogger;
import io.micrometer.core.util.internal.logging.InternalLoggerFactory;

import java.lang.reflect.Field;
import java.util.concurrent.*;
Expand All @@ -43,6 +45,9 @@
@NonNullApi
@NonNullFields
public class ExecutorServiceMetrics implements MeterBinder {

private static final InternalLogger log = InternalLoggerFactory.getInstance(ExecutorServiceMetrics.class);

static final String DEFAULT_EXECUTOR_METRIC_PREFIX = "";
@Nullable
private final ExecutorService executorService;
Expand Down Expand Up @@ -277,6 +282,8 @@ public void bindTo(MeterRegistry registry) {
monitor(registry, unwrapThreadPoolExecutor(executorService, executorService.getClass().getSuperclass()));
} else if (executorService instanceof ForkJoinPool) {
monitor(registry, (ForkJoinPool) executorService);
} else {
log.warn("Failed to bind as {} is unsupported.", className);
}
}

Expand Down

0 comments on commit 1dd19e6

Please sign in to comment.