Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #25

Merged
merged 23 commits into from
Oct 10, 2020
Merged

Add types #25

merged 23 commits into from
Oct 10, 2020

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Oct 3, 2020 •
edited

Add more type definitions based on the awesome work from @ChristianMurphy at #17

@codecov-commenter

This comment has been minimized.

Sign in to view
@ChristianMurphy ChristianMurphy mentioned this pull request Oct 3, 2020
Closed
@ocavue ocavue marked this pull request as ready for review October 3, 2020 23:59
@ocavue ocavue changed the title types: improve type definitions types: add type definitions Oct 4, 2020
wooorm
wooorm reviewed Oct 4, 2020
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @ocavue!

buffer.d.ts Outdated Show resolved Hide resolved
lib/compile/html.d.ts Outdated Show resolved Hide resolved
lib/index.d.ts Outdated Show resolved Hide resolved
lib/parse.d.ts Outdated Show resolved Hide resolved
lib/util/classify-character.d.ts Outdated Show resolved Hide resolved
shared-types.d.ts Outdated Show resolved Hide resolved
shared-types.d.ts Outdated Show resolved Hide resolved
shared-types.d.ts Outdated Show resolved Hide resolved
shared-types.d.ts Outdated Show resolved Hide resolved
shared-types.d.ts Outdated Show resolved Hide resolved
@ocavue ocavue requested a review from wooorm October 5, 2020 07:35
wooorm
wooorm reviewed Oct 5, 2020
View reviewed changes
lib/constant/unicode-punctuation-regex.js Outdated Show resolved Hide resolved
lib/index.d.ts Show resolved Hide resolved
lib/character/codes.d.ts Show resolved Hide resolved
micromark.test.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
shared-types.d.ts Outdated Show resolved Hide resolved
wooorm
wooorm reviewed Oct 5, 2020
View reviewed changes
shared-types.d.ts Outdated Show resolved Hide resolved
wooorm
wooorm reviewed Oct 5, 2020
View reviewed changes
lib/character/codes.d.ts Show resolved Hide resolved
lib/shared-types.d.ts Outdated Show resolved Hide resolved
script/copy-dict.js Outdated Show resolved Hide resolved
script/copy-dict.js Outdated Show resolved Hide resolved
script/generate-constant-typings.js Outdated Show resolved Hide resolved
@wooorm wooorm changed the title types: add type definitions Add types Oct 5, 2020
@wooorm
Copy link
Member

wooorm commented Oct 5, 2020

Btw, @ocavue, amazing work! Thanks!

@codecov-io

This comment has been minimized.

Sign in to view
wooorm
wooorm reviewed Oct 7, 2020
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me!

I am wondering what the rules are to what is typed or not, e.g., looking at util/, not everything has corresponding types?

@ocavue

This comment has been minimized.

Sign in to view
@ChristianMurphy

This comment has been minimized.

Sign in to view
@wooorm

This comment has been minimized.

Sign in to view
@ocavue

This comment has been minimized.

Sign in to view
ocavue
ocavue commented Oct 8, 2020
View reviewed changes
script/copy-dict.js Outdated Show resolved Hide resolved
@ocavue

This comment has been minimized.

Sign in to view
@wooorm

This comment has been minimized.

Sign in to view
@ocavue

This comment has been minimized.

Sign in to view
ocavue
ocavue commented Oct 8, 2020
View reviewed changes
lib/shared-types.d.ts Outdated Show resolved Hide resolved
wooorm
wooorm reviewed Oct 8, 2020
View reviewed changes
lib/shared-types.d.ts Outdated Show resolved Hide resolved
lib/shared-types.d.ts Outdated Show resolved Hide resolved
wooorm
wooorm reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two are my only suggestions?

I wonder what @ChristianMurphy, @fazouane-marouane think?

lib/shared-types.d.ts Outdated Show resolved Hide resolved
lib/shared-types.d.ts Outdated Show resolved Hide resolved
wooorm
wooorm reviewed Oct 8, 2020
View reviewed changes
tmp.sh Outdated Show resolved Hide resolved
ChristianMurphy
ChristianMurphy approved these changes Oct 8, 2020
View reviewed changes
lib/shared-types.d.ts Outdated Show resolved Hide resolved
ChristianMurphy
ChristianMurphy approved these changes Oct 9, 2020
View reviewed changes
lib/shared-types.d.ts Outdated Show resolved Hide resolved
@ocavue @ChristianMurphy
Update lib/shared-types.d.ts
fcecb8e 
Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
ChristianMurphy
ChristianMurphy approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ocavue! 🙇 👍 🎉

@wooorm wooorm merged commit 612aea8 into micromark:main Oct 10, 2020
@ocavue ocavue mentioned this pull request Oct 10, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@fazouane-marouane fazouane-marouane Awaiting requested review from fazouane-marouane

Assignees
No one assigned
Labels
☂️ area/types This affects typings 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ocavue @codecov-commenter @wooorm @codecov-io @ChristianMurphy