Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helpers: apply id and lang attr regexps to full string #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

helpers: apply id and lang attr regexps to full string #198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions helpers.go
View file
Open in desktop
Expand Up @@ -148,15 +148,15 @@ func (p *Policy) AllowStandardAttributes() {
p.AllowAttrs("dir").Matching(Direction).Globally()
p.AllowAttrs(
"lang",
).Matching(regexp.MustCompile(`[a-zA-Z]{2,20}`)).Globally()
).Matching(regexp.MustCompile(`^[a-zA-Z]{2,20}$`)).Globally()

// "id" is permitted. This is pretty much as some HTML elements require this
// to work well ("dfn" is an example of a "id" being value)
// This does create a risk that JavaScript and CSS within your web page
// might identify the wrong elements. Ensure that you select things
// accurately
p.AllowAttrs("id").Matching(
regexp.MustCompile(`[a-zA-Z0-9\:\-_\.]+`),
regexp.MustCompile(`^[a-zA-Z0-9\:\-_\.]+$`),
).Globally()

// "title" is permitted as it improves accessibility.
Expand Down