css: improve RGB hex color and length matching #142
Merged
+99
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow RGB hexadecimal colors in multiple formats per the spec. For
example, all of the following formats are valid.
#123
#123456
#12345678
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#rgb_colors
- Allow decimal lengths without a leading zero. For example, the all of
the following formats are valid.
.5em
0.5em
0
1em
https://developer.mozilla.org/en-US/docs/Web/CSS/length#syntax
|
I'm happy to merge this when the regexp's are made public (I see no reason that they're not public and I default public - see the ones in /helpers.go which are default public. |
- Perform regexp compilation only once by moving all regular expressions into global variables. - Update regexps to be written as `^...$` with `MatchString()` instead of using the `Longest()` with `FindString(value) == value && value != ""`.
|
I'm going to merge and rename things 👍 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow RGB hexadecimal colors in multiple formats per the spec. For
example, all of the following formats are valid.
#fff
#ffffff
#ffffffff
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#rgb_colors
Allow decimal lengths without a leading zero. For example, the all of
the following formats are valid.
.5em
0.5em
0
1em
https://developer.mozilla.org/en-US/docs/Web/CSS/length#syntax