Fix PHPStan issues and build on PHP 8.2 #368
Conversation
This reverts commit 30fcc97.
sanmai
changed the title
| @@ -24,11 +24,10 @@ | |||
| "psr-4": { "Michelf\\": "Michelf/" } | |||
| }, | |||
| "require-dev": { | |||
| "phpspec/prophecy": "^1.6", | |||
There was a problem hiding this comment.
There's no need for this dependency. See:
sebastianbergmann/phpunit#5033 (comment)
|
I see you're hitting some problems with the PHPStan and the tests. I think it's confused by the implicit treatment of DOMNode as DOMText (and perhaps other similar things). I tried to fix it in #377, but ended up fixing the wrong things and abandoned because I had not time left for this. Thank you for your work. |
This reverts commit 757c0e8.
| @@ -26,4 +26,5 @@ jobs: | |||
| - run: composer install --no-progress | |||
| # - run: composer codestyle | |||
| - run: composer phpstan | |||
| if: matrix.php == '8.1' | |||
There was a problem hiding this comment.
If we run PHPStan on every version, we'll use different versions of PHPStan detecting different sets of issues (due to bugs in older versions or whatnot).
|
@michelf Thanks for considering this PR! Please let me know if you need anything else or something isn't clear. Hopefully you can squash-merge this mess of commits. |
|
Build is passing 🎉 |
Looks like PHPStan is kinda lost here.