Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with context caveats #194

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Conversation

Chnapy
Copy link
Contributor

@Chnapy Chnapy commented Nov 10, 2020

Hi,

I wasted lot of debugging time because of context issues, similar to #93. Thanks to this issue and its comments I resolved my issues, but I think that talk about it in README would be a big help since it's a strange behavior + not a react-pixi-fiber bug (+ for people like me that waited long time before digging "context" related issues 馃檲 ).

So I did it to the "caveats" section. If you're ok with keeping it, feel free to suggest changes or even make changes directly 馃憤

(btw thanks for this lib, you saved me lot of work, saving me from duplicating React logic in Pixi environment 鉂わ笍 )

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d665268:

Sandbox Source
React Configuration
React Typescript Configuration
examples Configuration

Copy link
Owner

@michalochman michalochman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Chnapy, great idea, thanks for contributing! I will merge as is as the text is understandable.

@michalochman michalochman merged commit 237f541 into michalochman:master Nov 10, 2020
@Chnapy Chnapy deleted the patch-1 branch May 11, 2021 11:59
@0xdevalias
Copy link

This solution is also pointed out here: michalochman/react-pixi-fiber#93.

I'll close this issue now as it is not related to this lib but to React Context API.

In case anyone else stumbles here from Google/etc, react-pixi-fibre now lists this in it's 'caveats' section of the README:

This links to the following React issue:

Which seems to have been closed by this PR:

Which seems to have been included in the React 16.6.0 changelog in this PR:


I haven't looked any deeper into things that that yet, but at least in theory, I would expect that the React side of this bug/issue/weirdness should be fixed now. So it may 'just work'.

Originally posted by @0xdevalias in pixijs/pixi-react#77 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants