Ant and jenkins modes #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonjah
suggested changes
Apr 1, 2019
There was a problem hiding this comment.
@clayreimann I found a few issues, but I might have missed something.
I think it's common practice to give env variables priority over other config as they are more dynamic. But I guess you can go either way
|
@yonjah I've updated my PR with your comments. The tests are passing, maybe you could take it for a spin in whatever builds you're running to ensure it behaves as you expect? |
|
Thanks @clayreimann I'll try to do it today |
|
I ran my tests using this version and couldn't find any issues with the reports. |
|
And the crickets have it, merging as is. @soryy708, if you find bugs with this implementation open an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@yonjah I've combined #74 and #75 in this PR. I've somehow broken one of the Jenkins tests, I hope to fix it tomorrow.
I have slightly changed the behavior of your
deduceConfigfunction. The search order is nowconfig -> env -> defaultinstead ofenv -> config -> default. If you have a good argument for the older behavior, please share it. Otherwise please validate that I've faithfully merged your work in here.Closes #70
Closes #71
Closes #74
Closes #75