Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Actually invoke mocha instead of mocking it out #83

Closed
clayreimann opened this issue Apr 9, 2019 · 1 comment · Fixed by #120
Closed

Testing: Actually invoke mocha instead of mocking it out #83

clayreimann opened this issue Apr 9, 2019 · 1 comment · Fixed by #120

Comments

@clayreimann
Copy link
Collaborator

It was suggested, and would be a good idea, to actually invoke mocha from inside our tests to ensure that we conform to mocha's API.

Ironically, it may be necessary to use a separate test driver in order to actually accomplish this.
@clayreimann clayreimann mentioned this issue Apr 9, 2019
Merged
gabegorelick added a commit to gabegorelick/mocha-junit-reporter that referenced this issue May 10, 2020
@gabegorelick
tests: Actually invoke mocha instead of mocking it out
afde18b 
See michaelleeallen#83 for rationale.

In the future, it would be useful if we could test against multiple
versions of mocha instead of just the one listed in `devDependencies`.

Closes michaelleeallen#83
@gabegorelick gabegorelick mentioned this issue May 10, 2020
Merged
@gabegorelick
Copy link
Contributor

I've taken a stab at this in #120. So far it's highlighted a few potential bugs and some issues where the tests were making assumptions that weren't true.

gabegorelick added a commit to gabegorelick/mocha-junit-reporter that referenced this issue May 10, 2020
@gabegorelick
tests: Actually invoke mocha instead of mocking it out
391a1e7 
See michaelleeallen#83 for rationale.

In the future, it would be useful if we could test against multiple
versions of mocha instead of just the one listed in `devDependencies`.

Closes michaelleeallen#83
gabegorelick added a commit to gabegorelick/mocha-junit-reporter that referenced this issue May 25, 2020
@gabegorelick
tests: Actually invoke mocha instead of mocking it out
7339e23 
See michaelleeallen#83 for rationale.

In the future, it would be useful if we could test against multiple
versions of mocha instead of just the one listed in `devDependencies`.

Closes michaelleeallen#83
gabegorelick added a commit to gabegorelick/mocha-junit-reporter that referenced this issue May 25, 2020
@gabegorelick
tests: Actually invoke mocha instead of mocking it out
e0d8ffc 
See michaelleeallen#83 for rationale.

In the future, it would be useful if we could test against multiple
versions of mocha instead of just the one listed in `devDependencies`.

Closes michaelleeallen#83
clayreimann pushed a commit that referenced this issue Jun 7, 2020
@gabegorelick @clayreimann
tests: Actually invoke mocha instead of mocking it out
fababe6 
See #83 for rationale.

In the future, it would be useful if we could test against multiple
versions of mocha instead of just the one listed in `devDependencies`.

Closes #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: Actually invoke mocha instead of mocking it out gabegorelick/mocha-junit-reporter
2 participants
@gabegorelick @clayreimann