Fluent provider react18 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmonahan
reviewed
Jul 21, 2022
| @@ -3,25 +3,47 @@ import * as React from 'react'; | |||
| import type { FluentProviderState } from './FluentProvider.types'; | |||
| import { fluentProviderClassNames } from './useFluentProviderStyles'; | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| const useInsertionEffect = (React as any)['useInsertion' + 'Effect']; | |||
There was a problem hiding this comment.
I think we should add a comment here that explains why we write this as ['useInsertion' + 'Effect'].
There was a problem hiding this comment.
to be honest, i'm not sure if it is necessary as this repo has different rules than griffel
There was a problem hiding this comment.
In that case it's worth experimenting with a CRA app to see if we need to do this. In the linked Emotion issue the problem didn't pop up in Emotion but in a consumer of Emotion using React 17.
There was a problem hiding this comment.
It will cause problems on consumer side, please check microsoft#23625 (comment)
2 tasks
|
closing this as it was just a test run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
init approach of supporting fluent provider in react 18 strict mode