Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use number for user and/or group names #385

Merged
merged 3 commits into from Sep 14, 2023

Conversation

breezerider
Copy link
Contributor

  • add NumericUid and NumericGid to Tar struct
  • writeFileToArchive: set Uname and Gname to empty string if NumericUid and NumericGid are true, respectively.

* add NumericUid and NumericGid to Tar struct
* writeFileToArchive: set Uname and Gname to empty string if NumericUid and NumericGid are true, respectively.
@mholt
Copy link
Owner

mholt commented Sep 5, 2023

Thanks! Is there a reason one would be true but not the other?

@breezerider
Copy link
Contributor Author

No real use case on my side, just left it like that for flexibility. Primary use case is to prevent aliasing and this means both flags are set simultaneously. Do you think it makes sense to join them?

@mholt
Copy link
Owner

mholt commented Sep 11, 2023

I think we should probably join them unless there's a valid use case for having them separated. We're still in alpha so we could change this later if there's a valid use case brought forth.

* join NumericUid and NumericGid in Tar struct
* name the new option NumericUidGid
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is good. I'm just changing UidGid to UIDGID, as dumb as that looks, because the convention I'm used to capitalizes initialisms 🙃

I appreciate the change!!

tar.go Outdated Show resolved Hide resolved
tar.go Outdated Show resolved Hide resolved
@mholt mholt merged commit 1de2118 into mholt:master Sep 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants