Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go error wrapping on header writing for easier error handling #277

Merged
merged 1 commit into from Jan 12, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion tar.go
Expand Up @@ -386,7 +386,7 @@ func (t *Tar) Write(f File) error {

err = t.tw.WriteHeader(hdr)
if err != nil {
return fmt.Errorf("%s: writing header: %v", hdr.Name, err)
return fmt.Errorf("%s: writing header: %w", hdr.Name, err)
}

if f.IsDir() {
Expand Down
2 changes: 1 addition & 1 deletion zip.go
Expand Up @@ -420,7 +420,7 @@ func (z *Zip) Write(f File) error {

writer, err := z.zw.CreateHeader(header)
if err != nil {
return fmt.Errorf("%s: making header: %v", f.Name(), err)
return fmt.Errorf("%s: making header: %w", f.Name(), err)
}

return z.writeFile(f, writer)
Expand Down