Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate headers in Parser, based upon presence of _fields, without changing _input (fixes issue #985) #989

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Generate headers in Parser, based upon presence of _fields, without changing _input (fixes issue #985) #989

wants to merge 7 commits into from

Commits on Mar 24, 2023

  1. Use Parser to generate _fields for headers

    @landisdesign
    landisdesign committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    27cc377 View commit details
    Browse the repository at this point in the history

  2. Update test to ensure fields are sent every time

    @landisdesign
    landisdesign committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    86a6d27 View commit details
    Browse the repository at this point in the history

  3. Clean up extraneous return statement in buildHeaders

    @landisdesign
    landisdesign committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    b84183a View commit details
    Browse the repository at this point in the history

  4. Remove extraneous fields check from returnable

    @landisdesign
    landisdesign committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a151558 View commit details
    Browse the repository at this point in the history

  5. Clean up copying of fields to results 

    I *think* this is the last commit I have. Sigh.
    @landisdesign
    landisdesign committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    569c262 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Moved new test to bottom, reduced test data size

    @landisdesign
    landisdesign committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    80a8a92 View commit details
    Browse the repository at this point in the history

  2. Added a column back into the test 

    This lets us test duplicates in first row
    @landisdesign
    landisdesign committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    34fc5a0 View commit details
    Browse the repository at this point in the history