Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add property page #2

Closed
wants to merge 32 commits into from
Closed

Feature/add property page #2

wants to merge 32 commits into from

Conversation

mhd5uhail
Copy link
Owner

@mhd5uhail mhd5uhail commented Mar 14, 2023

Description

A property creation form that takes the user through the process of adding a property so that it may reviewed by the users on the platform

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

New UI Elements

  • Custom milestone progress bar
  • OutlinedDropDown
  • Bottom form navigation bar
  • SwipeToDismiss lazy column (Experimental api)

How is this section of the app laid out

  • The section of the app can be accessed through the main activity - contribute screen
  • AddPropertyFormContainer composable is treated as a parent composable for hosting several child Composables
  • An instance AddPropertyFormViewModel used for AddPropertyFormContainer is shared among AddressForm, AmenitiesForm, PictureDescForm and ReviewForm. (This allows to consolidate all the information collected in the form in a single ViewModel and also allows to maintain state of different form pages when moving back and forth between form pages)
  • Static data for drop down boxes used in the forms are loaded by the AddPropertyFormViewModel json files in the assets folder. Having this information as a json file makes updates flexible as the source code need not be changed.
  • The parsers for the static json files in assets are done using a Gson based parser. The parser was supposed to be made generic but due to a currently open issue in Gson the parsers are separate for each file.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Testing is required on form validation code
  • UI Testing needs to be done on individual forms

Additional Dependencies

Experimental Api's used

  • SwipeToDismiss

…r submission by using the swipe back gesture, this is due to a mistake in the navcontroller backstack logic implemented
…AddFeature dialog box created, Address form city/town selection added
…a, UnitTypeData Parsers seperately rather than creating generic type parser due to ongoing Gson issue #1107
…ough a repository, This would make it possible to Mock the asset repository for compose previews
… gets a representation of their posting. The Contact Card has been replaced with a Contributor Card. This includes an Upvote and Downvote button, their name and title.
@mhd5uhail
Copy link
Owner Author

Stale pull request. Will re-open when project is being actively worked on.

@mhd5uhail mhd5uhail closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant