Fixes out-of-bounds read vulnerability - CWE-125 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #7 |
mhart
reviewed
May 17, 2018
| @@ -27,6 +27,9 @@ StringStream.prototype.write = function(data) { | |||
| this.emit('error', err) | |||
| return false | |||
| } | |||
| if (typeof data !== 'string') { | |||
There was a problem hiding this comment.
This isn't right. data can be a Buffer.
Did you mean to check this.fromEncoding instead?
There was a problem hiding this comment.
Nope, I'm wrong – in any case, a better check is to ensure that data isn't a number
There was a problem hiding this comment.
ummm....how about........ !isNaN(data) ?
|
Closing in favor of #9 |
|
For anyone else tracking this down 2 years later, the relevant CVE is: CVE-2018-21270 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hackerone.com/reports/321670 for vulnerability details. Ideally this would be fixed with usage of
Buffer.from, but we add simple type-checking to keep compatibility with node<4.