Skip to content

Commit

Permalink
fix #622 (Rule 'var-naming' should allow Fuzz_xxx) (#623)
Browse files Browse the repository at this point in the history
  • Loading branch information
chavacava committed Jan 18, 2022
1 parent af953e6 commit b721f69
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 1 deletion.
7 changes: 6 additions & 1 deletion rule/var-naming.go
Expand Up @@ -145,7 +145,12 @@ func (w *lintNames) Visit(n ast.Node) ast.Visitor {
}
}
case *ast.FuncDecl:
if w.file.IsTest() && (strings.HasPrefix(v.Name.Name, "Example") || strings.HasPrefix(v.Name.Name, "Test") || strings.HasPrefix(v.Name.Name, "Benchmark")) {
funcName := v.Name.Name
if w.file.IsTest() &&
(strings.HasPrefix(funcName, "Example") ||
strings.HasPrefix(funcName, "Test") ||
strings.HasPrefix(funcName, "Benchmark") ||
strings.HasPrefix(funcName, "Fuzz")) {
return w
}

Expand Down
2 changes: 2 additions & 0 deletions test/var-naming_test.go
Expand Up @@ -11,4 +11,6 @@ func TestVarNaming(t *testing.T) {
testRule(t, "var-naming", &rule.VarNamingRule{}, &lint.RuleConfig{
Arguments: []interface{}{[]interface{}{"ID"}, []interface{}{"VM"}},
})

testRule(t, "var-naming_test", &rule.VarNamingRule{}, &lint.RuleConfig{})
}
12 changes: 12 additions & 0 deletions testdata/var-naming_test.go
@@ -0,0 +1,12 @@
// Test for name linting.

// Package pkg_with_underscores ...
package varnaming_test

var var_name int // MATCH /don't use underscores in Go names; var var_name should be varName/

func Test_ATest() {}
func Example_AnExample() {}
func Benchmark_ABenchmark() {}

func Fuzz_AFuzz() {}

0 comments on commit b721f69

Please sign in to comment.