Skip to content

Commit

Permalink
fix(core): display correct minimum in heatmap axis tooltip when there…
Browse files Browse the repository at this point in the history
  • Loading branch information
Akshat55 committed Sep 14, 2022
1 parent 7092cae commit 33d1bcc
Showing 1 changed file with 30 additions and 14 deletions.
44 changes: 30 additions & 14 deletions packages/core/src/components/graphs/heatmap.ts
Expand Up @@ -370,27 +370,43 @@ export class Heatmap extends Component {
const mainYScale = this.services.cartesianScales.getMainYScale();

let label = '',
sum = 0,
minimum = 0,
maximum = 0;
sum = null,
minimum = null,
maximum = null;

// Check to see where datum belongs
if (this.matrix[datum] !== undefined) {
label = domainLabel;
// Iterate through Object and get sum, min, and max
ranges.forEach((element) => {
let value = this.matrix[datum][element].value || 0;
sum += value;
minimum = value < minimum ? value : minimum;
maximum = value > maximum ? value : maximum;
if (typeof this.matrix[datum][element].value === 'number') {
let value = this.matrix[datum][element].value;
if (sum === null) {
sum = value;
minimum = value;
maximum = value;
return;
}
sum += value;
minimum = value < minimum ? value : minimum;
maximum = value > maximum ? value : maximum;
}
});
} else {
label = rangeLabel;
domains.forEach((element) => {
let value = this.matrix[element][datum].value || 0;
sum += value;
minimum = value < minimum ? value : minimum;
maximum = value > maximum ? value : maximum;
if (typeof this.matrix[element][datum].value === 'number') {
let value = this.matrix[element][datum].value;
if (sum === null) {
sum = value;
minimum = value;
maximum = value;
return;
}
sum += value;
minimum = value < minimum ? value : minimum;
maximum = value > maximum ? value : maximum;
}
});
}

Expand Down Expand Up @@ -426,15 +442,15 @@ export class Heatmap extends Component {
},
{
label: 'Min',
value: minimum,
value: minimum !== null ? minimum : '-',
},
{
label: 'Max',
value: maximum,
value: maximum !== null ? maximum : '-',
},
{
label: 'Average',
value: sum / domains.length,
value: sum !== null ? sum / domains.length : '-',
},
],
});
Expand Down

0 comments on commit 33d1bcc

Please sign in to comment.