feat: support setup script #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <script setup> tag is parsed by compiler-sfc as a scriptSetup in the returned descriptor.
meteorlxy
requested changes
May 27, 2021
| const endingTag = `</${type}>\n`; | ||
| const tagName = type === 'scriptSetup' ? 'script setup' : type; | ||
| const startingTag = `<${tagName}${lang ? ` lang="${lang}"` : ''}>`; | ||
| const endingTag = `</${tagName}>\n`; |
There was a problem hiding this comment.
Then the ending tag would be </script setup>
There was a problem hiding this comment.
Just add an extra condition like this:
const startingTag = `<${type}${type === 'scriptSetup' ? 'setup' : ''}${lang ? ` lang="${lang}"` : ''}>`;
|
The type of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The <script setup> tag is parsed by compiler-sfc as a scriptSetup in the
returned descriptor.
=========
Reference: <script setup> is an RFC that is available in vue 3.1.0-beta now.