Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update lifecycle methods for newer React #261

Closed
wants to merge 1 commit into from

Conversation

StorytellerCZ
Copy link
Collaborator

@StorytellerCZ StorytellerCZ commented Oct 26, 2018

Starting on a fix for #252 and #256 (and maybe #242)
Sadly it isn't as easy as replacing it with the recommended new methods (in short that breaks everything).
Moving componentWillMount functionality to constructor fixes that part, but componentWillUpdate has no easy backward compatible solution. So at least I'm presenting here this half fix and hopefully I can figure out something later or someone else can finish what I started. 馃

@StorytellerCZ StorytellerCZ changed the title Update lifecycle methods for newer React [WIP] Update lifecycle methods for newer React Oct 26, 2018
@CaptainN
Copy link
Collaborator

CaptainN commented Jul 11, 2019

You can just do the work in render instead of componentWillUpdate. ;-)

The hooks implementation in #262 actually takes care of this for React 16.8+, so there's probably not a whole lot of reason to mess with the old withTracker version, which will continue to work for React 16.7 and lower.

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2019

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@StorytellerCZ
Copy link
Collaborator Author

Well, this has been superseded by much better PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants