Deprecate stylus #9445
Deprecate stylus #9445
Conversation
Better / more up to date 3rd party stylus packages exist and there isn't really any technical reason why Meteor core needs to include its own stylus package. Since a stylus package can be fully built and managed outside of core, this commit moves the `stylus` package into `deprecated` (and preps the package contents for deprecation if we decide to publish a final version).
|
Hmm - failing |
|
Just to add more weight to the |
|
I found the reason for the failures. The failing tests have an indirect dependency on at least one Long story short - fixes are coming that involve adding a test |
Some of Meteor's package tests require at least one `.css` file to be available in the tested application bundle (e.g. "appcache - sections validity" and "webapp - content-type header"). The inclusion of this file makes sure that at least one `.css` file can always be found, when the tests are run.
|
I've committed changes to |
| @@ -0,0 +1,8 @@ | |||
| Package.describe({ | |||
| summary: 'DEPRECATED - Expressive, dynamic, robust CSS', | |||
| version: "2.513.14" | |||
There was a problem hiding this comment.
If we bump the minor to, say, 2.999.0, it could prevent (some, post-1.4.x) users from automatically updating to the deprecated version (and instead, leave them on the prior 2.513.13) when running meteor update --all-packages (or meteor update stylus). Then, since it wouldn't be "core" in future published Meteor versions, I believe they'd be allowed to keep using it @2.513.13 after that. Am I mistaken?
Otherwise LGTM.
There was a problem hiding this comment.
That makes sense to me @abernix - changes coming - thanks!
Putting the minor version at something unreachable to make sure the deprecated version isn't accidientally pulled into an app when running `meteor update --all-packages` or `meteor update stylus`.
@hwillson Do you have any recommendations? mquandalle:stylus and stolinski:stylus-multi seem to be the most popular alternatives but they were last updated 2-3 years ago. |
|
@ANault Try coagmano:stylus (it's essentially an up to date version of |
This code was recently removed in PR #9445, with this commit: d644705 Rather than removing deprecated code entirely from the codebase, I think it's sufficient to keep it in packages/deprecated, and print a deprecation notice whenever the package is used. This way it's clear that developers should migrate to other similar packages, but we can still release important patches for those who haven't been able to migrate yet. cc @hwillson @abernix
Update to @hwillson's recommended version see meteor/meteor#9445
Stylus is no longer supported in Meteor, and was never that popular, so remove from guide. meteor/meteor#9445
Better / more up to date 3rd party stylus packages exist and there isn't really any technical reason why Meteor core needs to include its own stylus package. Since a stylus package can be fully built and managed outside of core, this commit moves the
styluspackage intodeprecated.This PR also preps the package contents for deprecation if we decide to publish a final version. Publishing a final (deprecated) version probably isn't necessary, but the changes are included just in-case.