New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating minifier-js #11982
Updating minifier-js #11982
Conversation
…s mentioning terser instead of esbuild.
…se fields don't break.
- Updating history.md - Correcting variables' name
We encountered some challenges when trying to test the minify with SWC. We realized that the settings file used by the package wasn't being loaded correctly, so the code wasn't being minified all the way. On top of that, the minification time wasn't what we expected. Our assumption that SWC was faster than terser was based on this benchmark, but what we got was (in average):
The test was made in a new app with some features. It's possible that the big difference is because of the missing settings, hard to say. Based on all this, we decided to keep using terser for now, mainly because they released a new version fixing the issues we're having. I've already tested their solution, and it's working. I'll open a new PR updating terser to this new version soon. Thanks to everyone who reviewed it. |
From this issue and this one, we find out a bug on terser (minify package) that was affecting some applications (more of that here).
For that, we're replacing terser for SWC. With SWC we aren't just fixing those issues but also decreasing the minification time.