Fix long file paths passed to files.createTarball

The fix is actually in npm/fstream#42,
but now we also remove our explicit path length check
that used to throw an error instead of silently losing files.

This commit also adds a self-test to test the entire flow
through `files.createTarball` and `files.extractTarGz`.

scripts/dev-bundle-tool-package.js

@@ -28,7 +28,7 @@ var packageJson = {
     "source-map-support": "0.2.8",
     semver: "4.1.0",
     request: "2.47.0",
-    fstream: "1.0.2",
+    fstream: "https://github.com/meteor/fstream/tarball/d11b9ec4a13918447c8af7559c243c190744dd1c",
     tar: "1.0.2",
     kexec: "0.2.0",
     "source-map": "0.1.40",

tools/files.js

@@ -738,17 +738,6 @@ files.createTarGzStream = function (dirPath, options) {
         return true;
       }
 
-      // Error about long paths on Windows.
-      // As far as we know the tarball creation seems to fail silently when path
-      // is too long (the files don't get copied to tarball). To avoid it, we
-      // shout at the core developer early so she/he takes an action.
-      // When the tarball is created on Mac or Linux it doesn't seem to matter.
-      var maxPath = 260; // Longest allowed path length on Windows
-      if (entry.path.length > maxPath) {
-        throw new Error("Path too long: " + entry.path + " is " +
-          entry.path.length + " characters.");
-      }
-
       // Refuse to create a directory that isn't listable. Tarballs
       // created on Windows will have non-executable directories (since
       // executable isn't a thing in Windows directory permissions), and

tools/tests/tarball.js

@@ -0,0 +1,30 @@
+var selftest = require('../selftest.js');
+var files = require('../files.js');
+var expectEqual = selftest.expectEqual;
+
+selftest.define("create and extract tarball with long paths", function () {
+  var STAMP = "stamp";
+
+  // Create a directory with a single file in a long subdirectory, to
+  // be turned into a tarball.
+  var tarballInputDir = files.mkdtemp("tarball-input");
+  var longDir = tarballInputDir;
+  while (longDir.length < 300) {
+    longDir = files.pathJoin(longDir, "subdirectory");
+  }
+  files.mkdir_p(longDir);
+  var inputStampedFile = files.pathJoin(longDir, "file");
+  files.writeFile(inputStampedFile, STAMP);
+
+  // Make the tarball
+  var tarballOutputDir = files.mkdtemp("tarball");
+  var tarballOutputFile = files.pathJoin(tarballOutputDir, "out.tar.gz");
+  files.createTarball(tarballInputDir, tarballOutputFile);
+
+  // Extract the tarball and verify that the single file we created is
+  // present with the expected contents.
+  var tarballExtractedDir = files.mkdtemp("tarball-extracted");
+  files.extractTarGz(files.readFile(tarballOutputFile), tarballExtractedDir);
+  var extractedStampedFile = inputStampedFile.replace(tarballInputDir, tarballExtractedDir);
+  expectEqual(files.readFile(extractedStampedFile, "utf-8"), STAMP);
+});