Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/windows upload zerofiles #136

Merged
merged 3 commits into from Dec 13, 2021
Merged

Conversation

CAMOBAP
Copy link
Contributor

@CAMOBAP CAMOBAP commented Dec 10, 2021

No description provided.

@CAMOBAP CAMOBAP force-pushed the bugfix/windows-upload-zerofiles branch from b66c3b3 to 7394dbd Compare December 10, 2021 21:47
@ronaldtse
Copy link
Contributor

@CAMOBAP the fact that there is a zero-length file means there is some serious error in Metanorma processing. We need to find out which file it is and fix the problem.

@ronaldtse
Copy link
Contributor

ronaldtse commented Dec 11, 2021

@CAMOBAP FYI the issue about the broken PDF file is filed here: metanorma/metanorma-ogc#332

We might not want to avoid the zero-length issue as it is a real problem.

What we should fix instead is that if PDF processing fails we must fail the whole processing chain: metanorma/metanorma-cli#194

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Dec 11, 2021

We might not want to avoid the zero-length issue as it is a real problem.

Agree but this issue should be handled on metanorma-cli or metanorma-ogc level, not here.

BTW here is a ticket for 0-bytes file upload for windows actions/upload-artifact#281

One thing which I want to improve to not fail on timeout, @ronaldtse is it make sense?

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Dec 13, 2021

No built-in way to do this (check if timeout happens), I propose to merge this

@ronaldtse how do you think?

@CAMOBAP CAMOBAP merged commit 931527d into main Dec 13, 2021
@CAMOBAP CAMOBAP deleted the bugfix/windows-upload-zerofiles branch December 13, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants