Docker tag version must respect semver.org spec #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intro
docker/metadata-action
step force us to use semver.org. If we pass version which doesn't conform to semver.org spec if will 'silently fail' like this:Proposed solution
A script which will be used for such conversion was added to
metanorma-build-scripts
collection https://github.com/metanorma/metanorma-build-scripts/blob/main/gemver-to-semver.rbFor now it supports
chocolatey
andsemver
flagsOther possible solutions
Migrate to semver.org for our gems
Try to tune pattern here https://github.com/docker/metadata-action#semver (but I'm not sure that this is a good idea)
Proposal to add an input to allow fail on warnings docker/metadata-action#200 - added ticket to allow metadata step fails on wrong/unexpected input