feat: remove 'no' prefix in --no-progress and --no-install-fonts CLI flags #322 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -64,7 +64,7 @@ def compile(file_name = nil) | |||
| option :coverpage, aliases: "-c", desc: "Liquid template" | |||
| option :agree_to_terms, type: :boolean, desc: "Agree / Disagree with all third-party licensing terms "\ | |||
| "presented (WARNING: do know what you are agreeing with!)" | |||
| option :no_install_fonts, type: :boolean, desc: "Skip the font installation process" | |||
| option :install_fonts, type: :boolean, default: true, desc: "Install required fonts" | |||
| @@ -39,7 +39,7 @@ def new(name) | |||
| option :strict, aliases: "-S", type: :boolean, desc: "Strict compilation: abort if there are any errors" | |||
| option :agree_to_terms, type: :boolean, desc: "Agree / Disagree with all third-party licensing terms "\ | |||
| "presented (WARNING: do know what you are agreeing with!)" | |||
| option :no_install_fonts, type: :boolean, desc: "Skip the font installation process" | |||
| option :install_fonts, type: :boolean, default: true, desc: "Install required fonts" | |||
| class_option :no_progress, aliases: "-s", type: :boolean, default: true, | ||
| desc: "Don't show progress for long running tasks (like download)" | ||
| class_option :progress, aliases: "-s", type: :boolean, default: false, | ||
| desc: "Show progress for long running tasks (like download)" |
| @@ -18,7 +18,7 @@ class Site < ThorWithConfig | |||
| ) | |||
| option :agree_to_terms, type: :boolean, desc: "Agree / Disagree with all third-party licensing terms "\ | |||
| "presented (WARNING: do know what you are agreeing with!)" | |||
| option :no_install_fonts, type: :boolean, desc: "Skip the font installation process" | |||
| option :install_fonts, type: :boolean, default: true, desc: "Install required fonts" | |||
1 task
|
This proposed change is fine, but we must have a proper announcement / documentation change. |
I will prepare a blog post PR for metanorma.com |
CAMOBAP
force-pushed
the
feature/remove-no-prefix-in-progress-and-install-fonts-322
branch
from
0fad915
to
9d88e6f
Compare
|
@CAMOBAP Is this ready to review yet? |
CAMOBAP
force-pushed
the
feature/remove-no-prefix-in-progress-and-install-fonts-322
branch
2 times, most recently
from
15a4436
to
a7529b5
Compare
CAMOBAP
force-pushed
the
feature/remove-no-prefix-in-progress-and-install-fonts-322
branch
from
a7529b5
to
1537ba1
Compare
|
https://github.com/metanorma/metanorma-cli/actions/runs/9225953709 - is passed, I'm rollback Gemfile.devel |
CAMOBAP
force-pushed
the
feature/remove-no-prefix-in-progress-and-install-fonts-322
branch
from
1537ba1
to
5797b26
Compare
|
@opoudjis to be on the same page this PR is ready for review/merge. tests passed during https://github.com/metanorma/metanorma-cli/actions/runs/9225953709 run And metanorma/ci#167 has to be merged right before this one. Feel free to merge yourself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge order
Metanorma PR checklist