Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Uplift controller runtime, controller-tools , CAPI, IPAM and BMO modules #307

Merged
merged 3 commits into from
Oct 4, 2021
Merged

✨ Uplift controller runtime, controller-tools , CAPI, IPAM and BMO modules #307

merged 3 commits into from
Oct 4, 2021

Conversation

kashifest
Copy link
Member

In this PR we,

  • uplift controller-runtime to v0.10.1
  • uplift controller-tools to v0.7.0
  • uplift CAPI to v0.4.3
  • uplift BMO reference
  • uplift IPAM reference

First two changes are influenced by: kubernetes-sigs/cluster-api#5249

@metal3-io-bot metal3-io-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 29, 2021
@kashifest
Copy link
Member Author

/test-integration
/test-centos-integration

@kashifest
Copy link
Member Author

/assign @Xenwar
/cc @fmuyassarov @namnx228

@kashifest
Copy link
Member Author

/test-integration
/test-centos-integration

@kashifest
Copy link
Member Author

/test-integration

@kashifest
Copy link
Member Author

/test-integration
/test-centos-integration

@kashifest
Copy link
Member Author

/test-centos-integration

1 similar comment
@kashifest
Copy link
Member Author

/test-centos-integration

@jan-est
Copy link
Member

jan-est commented Oct 4, 2021

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2021
furkatgofurov7
furkatgofurov7 approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@metal3-io-bot metal3-io-bot merged commit 0161771 into metal3-io:master Oct 4, 2021
@furkatgofurov7 furkatgofurov7 mentioned this pull request Oct 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

@namnx228 namnx228 Awaiting requested review from namnx228

Assignees

@Xenwar Xenwar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kashifest @jan-est @metal3-io-bot @furkatgofurov7 @Xenwar