Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on finalize allocation function. #210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Aug 6, 2021

Improves the sequence of the finalize-allocation endpoint handler:

Closes #209.

@Gerrit91 Gerrit91 changed the title Improve stability of finalize allocation function. Improvements on finalize allocation function. Aug 6, 2021
@Gerrit91 Gerrit91 force-pushed the finalize-allocation-improvements branch from da2f6e1 to fd344e2 Compare August 9, 2021 10:51
@Gerrit91
Copy link
Contributor Author

Tried in mini-lab successfully along with the metal-hammer:

metal_api_image_tag: pr-finalize-allocation-improvements
metal_hammer_image_url: https://images.metal-stack.io/metal-hammer/pull-requests/57-wipe-disks/metal-hammer-initrd.img.lz4

@Gerrit91 Gerrit91 marked this pull request as ready for review August 17, 2021 09:40
Copy link
Contributor

@majst01 majst01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also should add a retry logic to the updateSwitch Logic in a additional PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Machine allocation succeeded flag never gets set
2 participants