Machine allocation succeeded flag never gets set #209
Comments
Gerrit91
changed the title
Gerrit91
added
help wanted
Gerrit91
added a commit
to metal-stack/gardener-extension-provider-metal
that referenced
this issue
Apr 4, 2022
The field is not set by metal-api anyway (see metal-stack/metal-api#209) and introduces a regression for migrated shoots.
Gerrit91
added a commit
to metal-stack/gardener-extension-provider-metal
that referenced
this issue
Apr 5, 2022
* Remove `succeeded` field from firewall status. The field is not set by metal-api anyway (see metal-stack/metal-api#209) and introduces a regression for migrated shoots. * Update controller-registration.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Maybe I miss something, but during investigation of #207 I found that the field
machine.Allocation.Succeededfield never gets set. I am very confused about this as I thought that this flag toggles infinalize-allocation. It doesn't. And also it seems like in the past it did not.This is actually dangerous as the metal-core uses this flag do decide whether it lets a machine boot the hammer or not: https://github.com/metal-stack/metal-core/blob/master/internal/endpoint/boot.go#L38
Also the GEPM uses this flag in the firewall reconciliation and it's kind of a miracle that the code just works.
The text was updated successfully, but these errors were encountered: