Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PyInstaller 4.3 #1797

Merged
merged 1 commit into from Apr 19, 2021
Merged

Upgrade to PyInstaller 4.3 #1797

merged 1 commit into from Apr 19, 2021

Conversation

phw
Copy link
Member

@phw phw commented Apr 18, 2021

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Use latest PyInstaller 4.3, see https://pyinstaller.readthedocs.io/en/stable/CHANGES.html#id1 for details.

For us interesting is the fix for pyinstaller/pyinstaller#5579:

Windows: Set EXE checksums. Reduces false-positive detection from antiviral software.

Having anti virus software detecting Picard or other PyInstaller based software as false positive is a recurring scheme. If this change reduces it that'd be great.

@phw phw merged commit 2ee74a9 into metabrainz:2.7.x Apr 19, 2021
@phw phw deleted the pyinstaller-4.3 branch April 19, 2021 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant