Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part of issue BB-768 : updating the edition model function #315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tarunmeena0901
Copy link

@Tarunmeena0901 Tarunmeena0901 commented Feb 13, 2024

Problem

BB-768

Part of PR 1051 in bookbrainz-site repo

Solution

added new creditSection argument and made some changes in autoCreateNewEditionGroup and createEditionGroupForNewEdition functions so the new auto created edition group get saved with the same state of credit section as of the edition it is created for

honestly I did not know how can i test these changes with bookbrainz-site , maybe creating my own package and copy the content with my changes from this and changing the links and package name to my npm package in package.json in bookbrainz-site, but as the changes were very small and simple this may just work 😶

Areas of Impact

edition model

Copy link
Contributor

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

The process I used to test this is pretty simple with the command yarn link in this repo, and yarn link bookbrainz-data in the bookbrainz-site repo to link them on my machine.
It basically creates a symbolic link to the data-js repo in bookbrainz-site's node_modules folder.

@MonkeyDo
Copy link
Contributor

Sorry I meant to approve not request changes 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants