replace search bar with command palette toggle #42603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
iethree
approved these changes
May 14, 2024
npfitz
force-pushed
the
42346-command-palette-search-button
branch
from
3a774f6
to
468ec6c
Compare
sloansparger
approved these changes
May 15, 2024
| @@ -202,9 +202,11 @@ function testOfficialBadgeInSearch({ | |||
| question, | |||
| expectBadge, | |||
| }) { | |||
| appBar().findByPlaceholderText("Search…").as("searchBar").type(searchQuery); | |||
| // appBar().findByPlaceholderText("Search…").as("searchBar").type(searchQuery); | |||
iethree
approved these changes
May 15, 2024
|
|
||
| ["admin", "normal"].forEach(user => { | ||
| describe(`search > ${user} user`, () => { | ||
| beforeEach(() => { | ||
| restore(); | ||
| cy.signIn(user); | ||
| cy.visit("/"); | ||
| // cy.visit("/"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42346
Description
PR swaps out the search bar for a button in the
AppBarcomponent when we are not embedded. Button should toggle the command palette. Tests were updated to eitherHow to verify
Demo
Checklist