Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column widths in Browse models #42601

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix column widths in Browse models #42601

merged 2 commits into from
May 14, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 13, 2024

Fixes the column widths and padding in Browse models to match Maz's spec, below:

image.png

Here's how the columns look in this branch:
image.png

This branch also retitles the page "Browsing models" per Dawei's request

Copy link
Contributor Author

rafpaf commented May 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 13, 2024
@rafpaf rafpaf marked this pull request as ready for review May 13, 2024 20:00
@graphite-app graphite-app bot added the no-backport Do not backport this PR to any branch label May 13, 2024
@graphite-app graphite-app bot requested a review from a team May 13, 2024 20:00
@rafpaf rafpaf changed the title wip Fix column widths in Browse models May 13, 2024
Copy link

graphite-app bot commented May 13, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (05/13/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

"Don't backport" took an action on this PR • (05/13/24)

1 label was added and 1 reviewer was added to this PR based on Raphael Krut-Landau's automation.

Copy link

replay-io bot commented May 13, 2024

Status Complete ↗︎
Commit 02ad1b5
Results
⚠️ 4 Flaky
2504 Passed

@rafpaf rafpaf merged commit 8b6e0bf into master May 14, 2024
111 checks passed
@rafpaf rafpaf deleted the browse/columns branch May 14, 2024 13:40
Copy link

@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants