-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unnecessary re-renderings in column settings sidebar #42595
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uladzimirdev this is "memo" + removing of props spreading to make it work, right?
@ranquild correct, memo allows to avoid re-renderings when parent component is re-rendered, using explicit props allows avoid passing unnecessary "changed" props.
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 9d968d9...d3a6991.
|
@uladzimirdev Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Improves performance of viz settings column picking
Before
Screen.Recording.2024-05-14.at.00.06.28.mov
After
Screen.Recording.2024-05-14.at.00.02.14.mov