Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove number-to-locale-string #42590

Merged
merged 2 commits into from
May 14, 2024
Merged

Remove number-to-locale-string #42590

merged 2 commits into from
May 14, 2024

Conversation

nemanjaglumac
Copy link
Member

@nemanjaglumac nemanjaglumac commented May 13, 2024 •
edited

The library was last updated six years ago!

Do we really need it anymore given that this method exists on the Number prototype natively?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toLocaleString

❯ yarn why number-to-locale-string
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "number-to-locale-string"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "number-to-locale-string@1.2.0"
info Has been hoisted to "number-to-locale-string"
info This module exists because it's specified in "dependencies".
info Disk size without dependencies: "192KB"
info Disk size with unique dependencies: "192KB"
info Disk size with transitive dependencies: "192KB"
info Number of shared dependencies: 0
✨  Done in 0.51s.

@nemanjaglumac nemanjaglumac added dependencies no-backport Do not backport this PR to any branch 🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something labels May 13, 2024
@nemanjaglumac nemanjaglumac requested a review from a team May 13, 2024 15:38
@nemanjaglumac nemanjaglumac self-assigned this May 13, 2024
@replay-io replay.io
Copy link

replay-io bot commented May 13, 2024 •
edited

Status In Progress ↗︎ 53 / 54
Commit 256dd9b
Results
⚠️ 4 Flaky
✅ 2503 Passed

@nemanjaglumac nemanjaglumac force-pushed the remove-number-to-locale-string branch from c9fb763 to 256dd9b Compare May 13, 2024 16:11
@nemanjaglumac nemanjaglumac merged commit 1d1bcdf into master May 14, 2024
111 checks passed
@nemanjaglumac nemanjaglumac deleted the remove-number-to-locale-string branch May 14, 2024 04:53
@github-actions GitHub Actions
Copy link

@nemanjaglumac Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafpaf rafpaf rafpaf approved these changes

Assignees

@nemanjaglumac nemanjaglumac

Labels
🧹 no-brainer cleanup issues to clear out when you have an hour left until EoD or something dependencies no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nemanjaglumac @rafpaf