Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete pulses when archiving dashboard #42558

Merged
merged 3 commits into from
May 14, 2024

Conversation

qnkhuat
Copy link
Contributor

@qnkhuat qnkhuat commented May 13, 2024

When archiving a dashboard, delete its pulses, which will delete all of its send-pulse quartz triggers.

Context: https://metaboat.slack.com/archives/C0641E4PB9B/p1715140747182479
Milestone 4 of: #41764

@qnkhuat qnkhuat requested a review from camsaul as a code owner May 13, 2024 10:40
@metabase-bot metabase-bot bot added the .Team/BackendComponents also known as BEC label May 13, 2024
@qnkhuat qnkhuat added the no-backport Do not backport this PR to any branch label May 13, 2024
Copy link

replay-io bot commented May 13, 2024

Status Complete ↗︎
Commit 1ca4f00
Results
⚠️ 8 Flaky
2500 Passed

@qnkhuat qnkhuat requested a review from a team May 14, 2024 09:48
Copy link
Contributor

@crisptrutski crisptrutski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just want to confirm we meant to delete that one method call.

src/metabase/models/dashboard.clj Outdated Show resolved Hide resolved
src/metabase/models/dashboard.clj Show resolved Hide resolved
@qnkhuat qnkhuat enabled auto-merge (squash) May 14, 2024 10:57
@qnkhuat qnkhuat merged commit b6b67a6 into master May 14, 2024
109 checks passed
@qnkhuat qnkhuat deleted the ngoc-delet-pulse-when-archvie-dashboard branch May 14, 2024 14:09
Copy link

@qnkhuat Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@qnkhuat qnkhuat changed the title Delete pulses when archive dashboard Delete pulses when archiving dashboard May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/BackendComponents also known as BEC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants